Skip to content

tiup: add 3 docs component-cluster-reload/enable/scale-out.md#5289

Merged
ti-chi-bot merged 17 commits into
pingcap:masterfrom
Joyinqin:tiup-joyin10
Apr 15, 2021
Merged

tiup: add 3 docs component-cluster-reload/enable/scale-out.md#5289
ti-chi-bot merged 17 commits into
pingcap:masterfrom
Joyinqin:tiup-joyin10

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Apr 12, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

add 3 docs:

  • tiup/tiup-component-cluster-repload.md
  • tiup/tiup-component-cluster-enable.md
  • tiup/tiup-component-cluster-scale-out.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 12, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@Joyinqin Joyinqin marked this pull request as ready for review April 13, 2021 02:42
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 13, 2021 •
edited
Loading

Wait for the #5270 and the translation of /tiup-dm-topology-reference.md to merge to fix the dead link.

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 13, 2021

/cc @lucklove @ran-huang

ran-huang
ran-huang reviewed Apr 13, 2021
View reviewed changes
Comment thread tiup/tiup-component-cluster-enable.md Outdated
Comment thread tiup/tiup-component-cluster-reload.md Outdated
Comment thread tiup/tiup-component-cluster-reload.md
Comment thread tiup/tiup-component-cluster-scale-out.md Outdated
Comment thread tiup/tiup-component-cluster-scale-out.md Outdated
Comment thread tiup/tiup-component-cluster-scale-out.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 13, 2021

/sig tiup

@ti-chi-bot ti-chi-bot added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Apr 13, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 13, 2021

/sig docs

@ti-chi-bot ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 13, 2021
lucklove
lucklove reviewed Apr 15, 2021
View reviewed changes
Comment thread tiup/tiup-component-cluster-scale-out.md Outdated
Comment on lines +17 to +18
`<cluster-name>`: the name of the cluster to operate on. If you forget the cluster name, you can check it with the [cluster list]<!-- (/tiup/tiup-component-dm-list.md) -->command.
`<topology.yaml>`: the prepared [topology file]<!--(/tiup/tiup-dm-topology-reference.md) -->. This topology file should only contain the new nodes that are to be added to the current cluster.
Copy link
Copy Markdown
Member

@lucklove lucklove Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should uncomment before merge.

@lucklove
Copy link
Copy Markdown
Member

lucklove commented Apr 15, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@ran-huang
Copy link
Copy Markdown
Contributor

ran-huang commented Apr 15, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d7ea7f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot merged commit 382ee6f into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5289 to release-4.0
c7222f9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 15, 2021

cherry pick to release-4.0 in PR #5339

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5289 to release-5.0
2f3330d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 15, 2021

cherry pick to release-5.0 in PR #5340

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 3 docs component-cluster-reload/enable/scale-out.md (#5289) (…
689bf7b 
…#5339)
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 3 docs component-cluster-reload/enable/scale-out.md (#5289) (…
150e4aa 
…#5340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove lucklove left review comments

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Joyinqin @lucklove @ti-chi-bot @ran-huang @ti-srebot