Skip to content

add tiup-cluster-topology-reference.md#5314

Merged
ti-chi-bot merged 9 commits into
pingcap:masterfrom
TomShawn:tiup-cliuster-topology-ref
Apr 16, 2021
Merged

add tiup-cluster-topology-reference.md#5314
ti-chi-bot merged 9 commits into
pingcap:masterfrom
TomShawn:tiup-cliuster-topology-ref

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

add tiup-cluster-topology-reference.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/translation from-docs-cn
/label require-LGT1
/cc @lucklove

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Apr 13, 2021
@ti-chi-bot ti-chi-bot requested a review from lucklove April 13, 2021 09:42
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 13, 2021
Comment thread tiup/tiup-cluster-topology-reference.md Outdated

`pd_servers` specifies the machines on which PD services are deployed. It also specifies the service configuration on each machine. `pd_servers` is an array, and each element of the array contains the following fields:

- `host`: Specifies the machine on which the PD services are deploy. The field value is the IP address and cannot be omitted.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `host`: Specifies the machine on which the PD services are deploy. The field value is the IP address and cannot be omitted.
- `host`: Specifies the machine on which the PD services are deployed. The field value is the IP address and cannot be omitted.

@TomShawn
Copy link
Copy Markdown
Contributor Author

/cc @Joyinqin @ran-huang

Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all lines above L380.
Just minor edits. Good job!

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

To deploy or scale TiDB using TiUP, you need to provide a topology file ([sample](https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml)) to describe the cluster topology.

Similarly, to modify the cluster topology, you need to modify the topology file. The difference is that you can only modify a part of the fields in the topology file. This document introduces each section of the topology file and each field in each section.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Similarly, to modify the cluster topology, you need to modify the topology file. The difference is that you can only modify a part of the fields in the topology file. This document introduces each section of the topology file and each field in each section.
Similarly, to modify the cluster topology, you need to modify the topology file. The difference is that you can modify only a part of the fields in the topology file. This document introduces each section of the topology file and each field in each section.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

A topology configuration file for TiDB deployment using TiUP might contains the following sections:

- [global](/tiup/tiup-cluster-topology-reference.md#global): The cluster's global configuration. Some of the configuration items use the default values and you can configure them separately in each instance.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [global](/tiup/tiup-cluster-topology-reference.md#global): The cluster's global configuration. Some of the configuration items use the default values and you can configure them separately in each instance.
- [global](#global): The cluster's global configuration. Some of the configuration items use the default values and you can configure them separately in each instance.

As I recall, self-referencing only needs an anchor name without a file name.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- If `global.deploy_dir` is a relative path, the component is deployed to the `/home/<global.user>/<global.deploy_dir>/<instance.deploy_dir>` directory.

- `data_dir`: The data directory. Default value: "data". Its application rules are as follows:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `data_dir`: The data directory. Default value: "data". Its application rules are as follows:
- `data_dir`: The data directory. Default value: `"data"`. Its application rules are as follows:

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- If `data_dir` is a relative path, the component data is placed in `<deploy_dir>/<data_dir>`. For the calculation rules of `<deploy_dir>`, see the application rules of the `deploy_dir` field.

- `log_dir`: The data directory. Default value: "log". Its application rules are as follows:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `log_dir`: The data directory. Default value: "log". Its application rules are as follows:
- `log_dir`: The data directory. Default value: `"log"`. Its application rules are as follows:

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `arch`: The CPU architecture of the target machine. This field determines the binary package of which platform is pushed to the target machine. Value options are `amd64` (default) and `arm64`.

- `resource_control`: Runtime resource control. All configurations in this field are written into the service file of systemd. There is no limit by default. The resources that support control are as follows:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `resource_control`: Runtime resource control. All configurations in this field are written into the service file of systemd. There is no limit by default. The resources that support control are as follows:
- `resource_control`: Runtime resource control. All configurations in this field are written into the service file of systemd. There is no limit by default. The resources that can be controled are as follows:

blackbox_exporter_port: 9115
```

The above configuration specifies that `node_exporter` uses the `9100` port and `blackbox_exporter` uses the `9115` port.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enclose other node_exporter in this doc with `.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

### `server_configs`

`server_configs` is used to configure services and to generate configuration files for each component, which is similar to the `global` section. The configuration of this section can be overwritten in a specific instance. `server_configs`mainly includes the following fields:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`server_configs` is used to configure services and to generate configuration files for each component, which is similar to the `global` section. The configuration of this section can be overwritten in a specific instance. `server_configs`mainly includes the following fields:
`server_configs` is used to configure services and to generate configuration files for each component, which is similar to the `global` section. The configuration of this section can be overwritten in a specific instance. `server_configs` mainly includes the following fields:

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `config`: The configuration rule of this field is the same as the `pd` configuration rule in `server_configs`. If this field is configured, the field content is merged with the `pd` content in `server_configs` (if the two fields overlap, the content of this field takes effect). Then, a configuration file is generated and sent to the machine specified in `host`.

- `os`: The operating system of the machine specified in`host`. If this field is not specified, the default value is the `os` value in `global`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `os`: The operating system of the machine specified in`host`. If this field is not specified, the default value is the `os` value in `global`.
- `os`: The operating system of the machine specified in `host`. If this field is not specified, the default value is the `os` value in `global`.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `port`: The listening port of the TiKV services. The default value is `20160`.

- `status_port`: The listening port of the TiDB status service. The default value is `20180`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `status_port`: The listening port of the TiDB status service. The default value is `20180`.
- `status_port`: The listening port of the TiKV status service. The default value is `20180`.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `config`: The configuration rule of this field is the same as the `tikv` configuration rule in `server_configs`. If this field is configured, the field content is merged with the `tikv` content in `server_configs` (if the two fields overlap, the content of this field takes effect). Then, a configuration file is generated and sent to the machine specified in `host`.

- `os`: The operating system of the machine specified in`host`. If this field is not specified, the default value is the `os` value in `global`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `os`: The operating system of the machine specified in`host`. If this field is not specified, the default value is the `os` value in `global`.
- `os`: The operating system of the machine specified in `host`. If this field is not specified, the default value is the `os` value in `global`.

Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, good job!

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
- `arch`
- `os`

A `pump_servers` configuration example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A `pump_servers` configuration example:
A `pump_servers` configuration example is as follows:

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
- `arch`
- `os`

A `drainer_servers` configuration example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `java_home`: Specifies the path in which the JRE environment to be used is located. This parameter corresponds to the `JAVA_HOME` system environment variable.

- `spark_config`: Used to configure the TiSpark services. Then, a configuration file is generated and sent to the machine specified in `host`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `spark_config`: Used to configure the TiSpark services. Then, a configuration file is generated and sent to the machine specified in `host`.
- `spark_config`: Configures the TiSpark services. Then, a configuration file is generated and sent to the machine specified in `host`.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
- `arch`
- `os`

A `tispark_masters` configuration example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `deploy_dir`: Specifies the deployment directory. If it is not specified or specified as a relative directory, the directory is generated according to the `deploy_dir` directory configured in `global`.

- `java_home`: Specifies the path in which the JRE environment to be used is located. This parameter corresponds to the `JAVA_HOME` system environment variable.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `java_home`: Specifies the path in which the JRE environment to be used is located. This parameter corresponds to the `JAVA_HOME` system environment variable.
- `java_home`: Specifies the path of the JRE environment to be used. This parameter corresponds to the `JAVA_HOME` system environment variable.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
Comment on lines +703 to +704
> + For the `*.json` files in the local dashboards directory, update the value of the `datasource` field to the new cluster name (because `datasource` is named after the cluster name).
> + Execute the `tiup cluster reload -R grafana` command.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> + For the `*.json` files in the local dashboards directory, update the value of the `datasource` field to the new cluster name (because `datasource` is named after the cluster name).
> + Execute the `tiup cluster reload -R grafana` command.
> 1. For the `*.json` files in the local dashboards directory, update the value of the `datasource` field to the new cluster name (because `datasource` is named after the cluster name).
> 2. Execute the `tiup cluster reload -R grafana` command.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
- `arch`
- `os`

A `grafana_servers` configuration example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `numa_node`: Allocates the NUMA policy to the instance. If this parameter is specified, you need to ensure that the target machine has [numactl](https://linux.die.net/man/8/numactl) installed. If this parameter is specified, cpubind and membind policies are allocated via [numactl](https://linux.die.net/man/8/numactl). This parameter field is the string type. The field value is the ID of the NUMA node, such as "0,1".

- `config_file`: This field specifies a local file that is transferred to the target machine during the initialization phase of the cluster configuration as the configuration of Alertmanager.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `config_file`: This field specifies a local file that is transferred to the target machine during the initialization phase of the cluster configuration as the configuration of Alertmanager.
- `config_file`: Specifies a local file that is transferred to the target machine during the initialization phase of the cluster configuration as the configuration of Alertmanager.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
- `arch`
- `os`

A `alertmanager_servers` configuration example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

`tispark_masters` specifies the machines on which the master node of TiSpark is deployed. It also specifies the service configuration on each machine. `tispark_masters` is an array. Each array element contains the following fields:

- `host`: Specifies the machine on which the TiSpark master is deploy. The field value is the IP address and cannot be omitted.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `host`: Specifies the machine on which the TiSpark master is deploy. The field value is the IP address and cannot be omitted.
- `host`: Specifies the machine on which the TiSpark master is deployed. The field value is the IP address and cannot be omitted.

@TomShawn
Copy link
Copy Markdown
Contributor Author

@Joyinqin @ran-huang @qiancai All comments are addressed. PTAL again, thanks!

Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Joyinqin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
@ran-huang
Copy link
Copy Markdown
Contributor

/lgtm

Comment thread tiup/tiup-cluster-topology-reference.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
Comment thread tiup/tiup-cluster-topology-reference.md Outdated
@lucklove
Copy link
Copy Markdown
Member

Rest LGTM

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- If `log_dir` is a relative path, the component log is placed in `<deploy_dir>/<log_dir>`. For the calculation rules of `<deploy_dir>`, see the application rules of the `deploy_dir` field.

- `os`: The operating system of the target machine. This field determines the components applicable to which system are pushed to the target machine. Its default value is `linux`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `os`: The operating system of the target machine. This field determines the components applicable to which system are pushed to the target machine. Its default value is `linux`.
- `os`: The operating system of the target machine. The field controls which operating system to adapt to for the components pushed to the target machine. The default value is "linux".

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `os`: The operating system of the target machine. This field determines the components applicable to which system are pushed to the target machine. Its default value is `linux`.

- `arch`: The CPU architecture of the target machine. This field determines the binary package of which platform is pushed to the target machine. Value options are `amd64` (default) and `arm64`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `arch`: The CPU architecture of the target machine. This field determines the binary package of which platform is pushed to the target machine. Value options are `amd64` (default) and `arm64`.
- `arch`: The CPU architecture of the target machine. The field controls which platform to adapt to for the binary packages pushed to the target machine. The supported values are "amd64" and "arm64". The default value is "amd64".

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `cpu_quota`: Limits the maximum CPU usage at runtime. For example, "200%".

- `io_read_bandwidth_max`: The maximum I/O bandwidth for disk reads. For example, `"/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M"`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `io_read_bandwidth_max`: The maximum I/O bandwidth for disk reads. For example, `"/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M"`.
- `io_read_bandwidth_max`: Limits the maximum I/O bandwidth for disk reads. For example, `"/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M"`.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `io_read_bandwidth_max`: The maximum I/O bandwidth for disk reads. For example, `"/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M"`.

- `io_write_bandwidth_max`: The maximum I/O bandwidth for disk writes. For example, `/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M`.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `io_write_bandwidth_max`: The maximum I/O bandwidth for disk writes. For example, `/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M`.
- `io_write_bandwidth_max`: Limits the maximum I/O bandwidth for disk writes. For example, `/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0 100M`.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

### `server_configs`

`server_configs` is used to configure services and to generate configuration files for each component, which is similar to the `global` section. The configuration of this section can be overwritten in a specific instance. `server_configs` mainly includes the following fields:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`server_configs` is used to configure services and to generate configuration files for each component, which is similar to the `global` section. The configuration of this section can be overwritten in a specific instance. `server_configs` mainly includes the following fields:
`server_configs` is used to configure services and to generate configuration files for each component. Similar to the `global` section, the configuration of this section can be overwritten by the configurations with the same names in an instance. `server_configs` mainly includes the following fields:

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

`pd_servers` specifies the machines to which PD services are deployed. It also specifies the service configuration on each machine. `pd_servers` is an array, and each element of the array contains the following fields:

- `host`: Specifies the machine to which the PD services are deployed. The field value is the IP address and cannot be omitted.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `host`: Specifies the machine to which the PD services are deployed. The field value is the IP address and cannot be omitted.
- `host`: Specifies the machine to which the PD services are deployed. The field value is an IP address and is mandatory.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `listen_host`: When the machine has multiple IP addresses, `listen_host` specifies the listening IP address of the service. The default value is `0.0.0.0`.

- `ssh_port`: The SSH port used when connecting to the target machine for operations. If it is not specified, the `ssh_port` of the `global` section is used.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `ssh_port`: The SSH port used when connecting to the target machine for operations. If it is not specified, the `ssh_port` of the `global` section is used.
- `ssh_port`: Specifies the SSH port to connect to the target machine for operations. If it is not specified, the `ssh_port` of the `global` section is used.

Comment thread tiup/tiup-cluster-topology-reference.md Outdated

- `log_dir`: Specifies the log directory. If it is not specified or specified as a relative directory, the log is generated according to the `log_dir` directory configured in `global`.

- `numa_node`: Allocates the NUMA policy to the instance. If this parameter is specified, you need to ensure that the target machine has [numactl](https://linux.die.net/man/8/numactl) installed. When this parameter is specified, cpubind and membind policies are allocated via [numactl](https://linux.die.net/man/8/numactl). This parameter field is the string type. The field value is the ID of the NUMA node, such as "0,1".
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `numa_node`: Allocates the NUMA policy to the instance. If this parameter is specified, you need to ensure that the target machine has [numactl](https://linux.die.net/man/8/numactl) installed. When this parameter is specified, cpubind and membind policies are allocated via [numactl](https://linux.die.net/man/8/numactl). This parameter field is the string type. The field value is the ID of the NUMA node, such as "0,1".
- `numa_node`: Allocates the NUMA policy to the instance. Before specifying this field, you need to make sure that the target machine has [numactl](https://linux.die.net/man/8/numactl) installed. If this field is specified, cpubind and membind policies are allocated using [numactl](https://linux.die.net/man/8/numactl). This field is the string type. The field value is the ID of the NUMA node, such as "0,1".

@TomShawn TomShawn requested a review from qiancai April 15, 2021 09:32
@TomShawn
Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 00273f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 074fa7d into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #5355

@TomShawn TomShawn deleted the tiup-cliuster-topology-ref branch April 16, 2021 05:24
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #5356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants