TiUP: Add tiup-dm-topology-reference.md#5318
Merged
ti-chi-bot merged 17 commits intoApr 16, 2021
Merged
Conversation
ti-chi-bot
added
missing-translation-status
Collaborator
Author
|
/label needs-cherry-pick-4.0 |
ti-chi-bot
added
status/PTAL
qiancai
changed the title
Contributor
|
/cc @ran-huang |
ran-huang
reviewed
Apr 14, 2021
|
|
||
| The topology file of a DM cluster might contain the following blocks: | ||
|
|
||
| - [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. |
Contributor
There was a problem hiding this comment.
Suggested change
| - [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. | |
| - [global](#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. |
Self-referencing only needs an anchor name without a file name.
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
…up-dm-topology-reference
TomShawn
reviewed
Apr 15, 2021
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
Good job! These are just minor edits.
lucklove
reviewed
Apr 16, 2021
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: SIGSEGV <gnu.crazier@gmail.com> Co-authored-by: Allen Zhong <allen@moe.cat>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
…up-dm-topology-reference
…up-dm-topology-reference
Member
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
ran-huang
reviewed
Apr 16, 2021
Contributor
ran-huang
left a comment
ran-huang
left a comment
There was a problem hiding this comment.
Rest LGTM
A global comment: please limit the use of future tenses.
Co-authored-by: Ran <huangran@pingcap.com>
Contributor
|
/lgtm |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 494b022 |
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-4.0 in PR #5367 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
|
cherry pick to release-5.0 in PR #5368 |
Contributor
|
/run-cherry-picker |
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add tiup-dm-topology-reference.md
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?