Skip to content

tiup: add tiup-reference.md#5322

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
TomShawn:tiup-referencesw1
Apr 16, 2021
Merged

tiup: add tiup-reference.md#5322
ti-chi-bot merged 6 commits into
pingcap:masterfrom
TomShawn:tiup-referencesw1

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Apr 14, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

tiup: add tiup-reference.md

This document can be merged after all other TiUP docs are merged.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2021
@TomShawn TomShawn changed the title tiup: add tiup-reference.md [pending for all other tiup docs] tiup: add tiup-reference.md Apr 14, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 14, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn
/label require-LGT1
/cc @Joyinqin @lucklove

@ti-chi-bot ti-chi-bot requested review from Joyinqin and lucklove April 14, 2021 05:17
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@TomShawn TomShawn changed the title [pending for all other tiup docs] tiup: add tiup-reference.md [pending on all other tiup docs] tiup: add tiup-reference.md Apr 14, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2021
Joyinqin
Joyinqin reviewed Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm~

Comment thread tiup/tiup-reference.md Outdated
Comment thread tiup/tiup-reference.md Outdated

### -B, --binary

- Data type: `BOOLEAN`
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the order of the list to keep it consistent with the form of other prs.

Copy link
Copy Markdown
Contributor Author

@TomShawn TomShawn Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e2a2c16.

Comment thread tiup/tiup-reference.md Outdated
TomShawn and others added 2 commits April 16, 2021 10:30
@TomShawn @Joyinqin
Update tiup/tiup-reference.md
746d883 
Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@TomShawn @Joyinqin
Update tiup/tiup-reference.md
a0d7084 
Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@lucklove
Copy link
Copy Markdown
Member

lucklove commented Apr 16, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 16, 2021

/lgtm

@TomShawn TomShawn changed the title [pending on all other tiup docs] tiup: add tiup-reference.md tiup: add tiup-reference.md Apr 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: aeb2db8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 2c1d558 into pingcap:master Apr 16, 2021
@TomShawn TomShawn deleted the tiup-referencesw1 branch April 16, 2021 11:18
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5322 to release-4.0
fd7fe80 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-4.0 in PR #5371

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5322 to release-5.0
369cf74 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-5.0 in PR #5372

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add tiup-reference.md (#5322) (#5371)
461ac77
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add tiup-reference.md (#5322) (#5372)
958a4a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove Awaiting requested review from lucklove

1 more reviewer

@Joyinqin Joyinqin Joyinqin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TomShawn @lucklove @ti-chi-bot @Joyinqin @ti-srebot