comment-syntax: Correct the note about --comments (#5421)#5427
Merged
ti-chi-bot merged 1 commit intoApr 22, 2021
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
Author
|
@dveeden you're already a collaborator in bot's repo. |
Contributor
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: fc50624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #5421 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In docs repo: git pr https://github.com/pingcap/docs/pull/5427After apply modifications, you can push your change to this PR via:
What is changed, added or deleted? (Required)
With the 8.0.23 MySQL client TiDB specific comments are cleared out, so
even with the latest client you still need to add
--comments.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?