Skip to content

system-variables: ensure alphabetical order (#5711)#5715

Closed
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-5711-to-release-5.0
Closed

system-variables: ensure alphabetical order (#5711)#5715
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-5711-to-release-5.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #5711

What is changed, added or deleted? (Required)

The system variables are not in alphabetical order. This is useful for users when a list is long because it makes it easier to search for them. I also plan to auto-generate the system-variables page from the server's variables list, but it's not possible to do when the order is non-deterministic.

I have made one other small edit, which is to normalize the introduced version and remove the text " version" when it appears. I will fix the CI if this breaks any anchors.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels May 28, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 28, 2021 05:44
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2021
@TomShawn TomShawn removed their request for review May 28, 2021 11:36
@TomShawn TomShawn removed requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels May 28, 2021
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label May 28, 2021
@TomShawn TomShawn closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants