Skip to content

system-variables: add datadir and license#5761

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
morgo:add-docs
Jun 29, 2021
Merged

system-variables: add datadir and license#5761
ti-chi-bot merged 5 commits into
pingcap:masterfrom
morgo:add-docs

Conversation

@morgo
Copy link
Copy Markdown
Contributor

@morgo morgo commented Jun 9, 2021

What is changed, added or deleted? (Required)

This adds 2 missing system variables that function correctly in TiDB: datadir and license.

The language is intentionally a little vague and says "typically" because in mocktikv/unistore cases it will show a path, but that is for developers to know. I don't believe we ever change the license string for enterprise edition but the language doesn't preclude that.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@morgo morgo requested a review from dveeden June 9, 2021 01:01
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2021
@TomShawn TomShawn added the translation/doing This PR's assignee is translating this PR. label Jun 10, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 10, 2021
TomShawn
TomShawn reviewed Jun 10, 2021
View reviewed changes
Comment thread system-variables.md Outdated
dveeden
dveeden approved these changes Jun 10, 2021
View reviewed changes
Comment thread system-variables.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
morgo and others added 2 commits June 10, 2021 09:22
@morgo @dveeden
Update system-variables.md
cf1652b 
Co-authored-by: Daniël van Eeden <github@myname.nl>
@morgo @TomShawn
Update system-variables.md
4ae6ae3 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2021
@TomShawn TomShawn requested a review from xhebox June 28, 2021 02:21
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

@xhebox: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Jun 28, 2021
View reviewed changes
Comment thread system-variables.md Outdated
TomShawn
TomShawn approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2021
@morgo @TomShawn
Update system-variables.md
9600fcf 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9600fcf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@ti-chi-bot ti-chi-bot merged commit 7253ade into pingcap:master Jun 29, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 29, 2021
@morgo @ti-chi-bot
system-variables: add datadir and license (pingcap#5761)
702a35c
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

In response to a cherrypick label: new pull request created: #5890.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 29, 2021
@morgo @ti-chi-bot
This is an automated cherry-pick of pingcap#5761
819164b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

In response to a cherrypick label: new pull request created: #5891.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

In response to a cherrypick label: new pull request created: #5892.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jun 29, 2021
@ti-chi-bot
system-variables: add datadir and license (#5761) (#5890)
b718358
ti-chi-bot added a commit that referenced this pull request Jun 29, 2021
@ti-chi-bot
system-variables: add datadir and license (#5761) (#5892)
6ebc9bb
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 1, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Jul 1, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 1, 2021
This was referenced Jul 5, 2021
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
@ti-chi-bot
system-variables: add datadir and license (#5761) (#5891)
13a519e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dveeden dveeden dveeden approved these changes

@xhebox xhebox xhebox approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morgo @ti-chi-bot @TomShawn @Liuxiaozhen12 @dveeden @xhebox