Skip to content

Delete docker deployment docs#5830

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
TomShawn:dele-docker-docs
Jun 23, 2021
Merged

Delete docker deployment docs#5830
ti-chi-bot merged 1 commit into
pingcap:masterfrom
TomShawn:dele-docker-docs

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Jun 23, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn requested a review from Joyinqin June 23, 2021 09:28
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Jun 23, 2021
@TomShawn TomShawn requested a review from lilyjazz June 23, 2021 09:28
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 23, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 23, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Joyinqin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2021
lilyjazz
lilyjazz approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

@lilyjazz: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jun 23, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 30effb8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit 6de845f into pingcap:master Jun 23, 2021
@lilyjazz lilyjazz mentioned this pull request Jun 23, 2021
Closed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 23, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#5830
28aeb52 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

In response to a cherrypick label: new pull request created: #5831.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 23, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#5830
f31d875 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

In response to a cherrypick label: new pull request created: #5832.

@TomShawn TomShawn deleted the dele-docker-docs branch June 23, 2021 09:46
ti-chi-bot added a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
Delete docker deployment docs (#5830) (#5831)
d340de4
ti-chi-bot added a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
Delete docker deployment docs (#5830) (#5832)
10e91bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilyjazz lilyjazz lilyjazz approved these changes

+1 more reviewer

@Joyinqin Joyinqin Joyinqin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-chi-bot @lilyjazz @Joyinqin