Skip to content

tidb-functions: extend tidb_decode_key docs#5877

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
dveeden:tidb_decode_key
Jun 29, 2021
Merged

tidb-functions: extend tidb_decode_key docs#5877
ti-chi-bot merged 1 commit into
pingcap:masterfrom
dveeden:tidb_decode_key

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Jun 28, 2021

What is changed, added or deleted? (Required)

Extend documentation for TIDB_DECODE_KEY

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Closes: #5561

@dveeden dveeden requested review from TomShawn and kolbe June 28, 2021 09:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 translation/doing This PR's assignee is translating this PR. labels Jun 28, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 28, 2021
kolbe
kolbe approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 28, 2021

@kolbe: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Jun 29, 2021
View reviewed changes
Comment thread functions-and-operators/tidb-functions.md Outdated
TomShawn
TomShawn reviewed Jun 29, 2021
View reviewed changes
Comment thread functions-and-operators/tidb-functions.md Outdated
@dveeden @TomShawn
tidb-functions: extend tidb_decode_key docs
a9cdd1e 
Closes: pingcap#5561

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@dveeden dveeden requested a review from TomShawn June 29, 2021 04:38
TomShawn
TomShawn approved these changes Jun 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 29, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a9cdd1e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@ti-chi-bot ti-chi-bot merged commit d00a121 into pingcap:master Jun 29, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
7 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

In response to a cherrypick label: new pull request created: #5886.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 29, 2021

In response to a cherrypick label: new pull request created: #5887.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2021
Merged
7 tasks
ti-chi-bot added a commit that referenced this pull request Jun 29, 2021
@ti-chi-bot
tidb-functions: extend tidb_decode_key docs (#5877) (#5886)
2352398
ti-chi-bot added a commit that referenced this pull request Jun 29, 2021
@ti-chi-bot
tidb-functions: extend tidb_decode_key docs (#5877) (#5887)
a9c84a2
@Joyinqin Joyinqin mentioned this pull request Jul 8, 2021
Merged
12 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Jul 8, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 8, 2021
This was referenced Jul 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kolbe kolbe kolbe approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add documentation for tidb_decode_key

5 participants

@dveeden @ti-chi-bot @TomShawn @Joyinqin @kolbe