Skip to content

Clarify tidb lightning backend description#5904

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:tidb-lightning-backends
Jul 1, 2021
Merged

Clarify tidb lightning backend description#5904
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:tidb-lightning-backends

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Clarify tidb lightning backend description

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 1, 2021 08:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.0 and removed missing-translation-status This PR does not have translation status info. labels Jul 1, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from kennytm July 1, 2021 08:26
@ti-chi-bot
Copy link
Copy Markdown
Member

@kennytm: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Comment thread tidb-lightning/deploy-tidb-lightning.md Outdated
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 1, 2021

/remove-status LGT1
/status LGT2

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 1, 2021

/merge

@TomShawn TomShawn added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jul 1, 2021
@ti-chi-bot ti-chi-bot merged commit 8bad841 into pingcap:master Jul 1, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #5905.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #5906.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 1, 2021

/run-cherry-picker

@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: These labels are not set on the issue: status/lgt1.

Details

In response to this:

/remove-status LGT1
/status LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #5907.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 460a768

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 1, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs#release-5.1 from head ti-chi-bot:cherry-pick-5904-to-release-5.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5904-to-release-5.1."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants