Skip to content

Delete a line set @@tidb_opt_broadcast_join=0;#6088

Merged
ti-chi-bot merged 1 commit into
release-5.0from
delete-a-line
Aug 4, 2021
Merged

Delete a line set @@tidb_opt_broadcast_join=0;#6088
ti-chi-bot merged 1 commit into
release-5.0from
delete-a-line

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Aug 4, 2021

What is changed, added or deleted? (Required)

Deleted a line set @@tidb_opt_broadcast_join=0;

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn August 4, 2021 03:48
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 4, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2021
@hfxsd hfxsd added needs-cherry-pick-release-5.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 4, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 4, 2021
@TomShawn TomShawn changed the base branch from master to release-5.0 August 4, 2021 03:51
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 4, 2021
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 4, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 4, 2021

/rebase

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 4, 2021

@hfxsd Please add the translation/from-docs-cn label instead of the translation/done label. Thanks!

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8df3b7e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@ti-chi-bot ti-chi-bot merged commit ec925d2 into release-5.0 Aug 4, 2021
@TomShawn TomShawn deleted the delete-a-line branch November 8, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants