Skip to content

Update tidb-lightning-faq.md from OnCALL#6840

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
hfxsd:Update-tidb-lightning-faq.md-from-OnCALL
Nov 19, 2021
Merged

Update tidb-lightning-faq.md from OnCALL#6840
ti-chi-bot merged 5 commits into
pingcap:masterfrom
hfxsd:Update-tidb-lightning-faq.md-from-OnCALL

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Nov 18, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Updated possible reasons for checksum failed: checksum mismatched remote vs local.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this Nov 18, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn November 18, 2021 02:54
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2021
@hfxsd hfxsd requested review from Liuxiaozhen12 and glorv November 18, 2021 02:55
@hfxsd hfxsd added needs-cherry-pick-release-5.0 type/enhancement The issue or PR belongs to an enhancement. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 18, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 18, 2021
glorv
glorv reviewed Nov 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
@hfxsd @glorv
Apply suggestions from code review
536c9e3 
Co-authored-by: glorv <glorvs@163.com>
glorv
glorv reviewed Nov 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hfxsd hfxsd requested a review from lance6716 November 18, 2021 06:56
lance6716
lance6716 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need address comment

Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
hfxsd and others added 2 commits November 19, 2021 20:18
@hfxsd @lance6716
Update tidb-lightning/tidb-lightning-faq.md
fffd9bb 
Co-authored-by: lance6716 <lance6716@gmail.com>
@hfxsd @lance6716
Update tidb-lightning/tidb-lightning-faq.md
f004389 
Co-authored-by: lance6716 <lance6716@gmail.com>
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Nov 19, 2021

/verify

@Liuxiaozhen12 Liuxiaozhen12 added the ONCALL Relates to documentation oncall. label Nov 19, 2021
Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 19, 2021
View reviewed changes
Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
Comment thread tidb-lightning/tidb-lightning-faq.md Outdated
@hfxsd @Liuxiaozhen12
Apply suggestions from code review
5be39c6 
Co-authored-by: Liuxiaozhen12 <82579298+Liuxiaozhen12@users.noreply.github.com>
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Nov 19, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 19, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Nov 19, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5be39c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2021
@ti-chi-bot ti-chi-bot merged commit f5e7950 into pingcap:master Nov 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 19, 2021

In response to a cherrypick label: new pull request created: #6880.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 19, 2021

In response to a cherrypick label: new pull request created: #6881.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 19, 2021

In response to a cherrypick label: new pull request created: #6882.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 19, 2021

In response to a cherrypick label: new pull request created: #6883.

ti-chi-bot added a commit that referenced this pull request Nov 22, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#6840) (#6883)
3f09246
ti-chi-bot added a commit that referenced this pull request Nov 22, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#6840) (#6882)
05a2938
ti-chi-bot added a commit that referenced this pull request Nov 22, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#6840) (#6881)
a9846bd
ti-chi-bot added a commit that referenced this pull request Nov 22, 2021
@ti-chi-bot
Update tidb-lightning-faq.md from OnCALL (#6840) (#6880)
7e07b50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv left review comments

@lance6716 lance6716 lance6716 approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

+1 more reviewer

@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

Labels

area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hfxsd @ti-chi-bot @Liuxiaozhen12 @lance6716 @glorv