Skip to content

Conversation

@lilyjazz
Copy link
Member

@lilyjazz lilyjazz commented Apr 1, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 April 1, 2022 04:31
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@shichun-0415 shichun-0415 added translation/no-need No need to translate this PR. needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed missing-translation-status This PR does not have translation status info. labels Apr 1, 2022
@shichun-0415 shichun-0415 requested a review from breezewish April 1, 2022 05:46
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2022
@qiancai
Copy link
Collaborator

qiancai commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 87be303

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@qiancai qiancai merged commit f11ceba into pingcap:master Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8014.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8015.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8016.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8017.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8018.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8019.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8020.

@shichun-0415 shichun-0415 changed the title Update telemetry.md Update the link of privacy policy Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants