Skip to content

sql: allow_invalid_dates is now supported#853

Merged
CaitinChen merged 2 commits into
masterfrom
morgo/sql-mode-update
Jan 28, 2019
Merged

sql: allow_invalid_dates is now supported#853
CaitinChen merged 2 commits into
masterfrom
morgo/sql-mode-update

Conversation

@morgo
Copy link
Copy Markdown
Contributor

@morgo morgo commented Jan 15, 2019

@morgo morgo added the v3.0 label Jan 15, 2019
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Jan 15, 2019

PTAL @jackysp , @CaitinChen

@morgo morgo requested review from CaitinChen and jackysp January 15, 2019 02:06
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Jan 15, 2019

Actually, I didn't realize #771 was not merged. I will close this request and combine the two.

Edit: It's an old PR, I thought it covered more on sql modes. This seems unrelated, so I will keep it in this PR.

@morgo morgo closed this Jan 15, 2019
@morgo morgo reopened this Jan 15, 2019
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread sql/mysql-compatibility.md Outdated
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Jan 25, 2019

Feedback addressed. @CaitinChen PTAL

Copy link
Copy Markdown
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen merged commit c4b9fa8 into master Jan 28, 2019
@CaitinChen CaitinChen deleted the morgo/sql-mode-update branch January 28, 2019 02:58
yikeke pushed a commit to yikeke/docs-cn that referenced this pull request Jan 29, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants