Skip to content

feat(error): support go 1.13 errors.Unwrap method#6

Merged
lonng merged 2 commits intopingcap:masterfrom
zeromake:master
Mar 6, 2020
Merged

feat(error): support go 1.13 errors.Unwrap method#6
lonng merged 2 commits intopingcap:masterfrom
zeromake:master

Conversation

@zeromake
Copy link
Copy Markdown
Contributor

close #5

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 5, 2020

CLA assistant check
All committers have signed the CLA.

@zeromake zeromake mentioned this pull request Mar 5, 2020
Copy link
Copy Markdown
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, please change the year 2017 to 2020 in the license header.

Comment thread error.go Outdated
Comment thread go113.go Outdated
Comment thread error_test.go Outdated
Comment thread pre_go113.go Outdated
Copy link
Copy Markdown
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@zeromake
Copy link
Copy Markdown
Contributor Author

zeromake commented Mar 6, 2020

@lonng Issues in code review have been fixed

@lonng
Copy link
Copy Markdown
Contributor

lonng commented Mar 6, 2020

@zeromake Thanks for your contribution.

@lonng lonng merged commit d5540d3 into pingcap:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unhandled error unpacking

3 participants