Skip to content

Update the errors dependence to the latest version#1079

Merged
lonng merged 2 commits into
masterfrom
update-errors
Nov 9, 2020
Merged

Update the errors dependence to the latest version#1079
lonng merged 2 commits into
masterfrom
update-errors

Conversation

@lonng
Copy link
Copy Markdown
Contributor

@lonng lonng commented Nov 9, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

The PR pingcap/tiup#867 introduces functions that will merge the workaround/description from errors.toml with the error message from the repository. Make sure there are no conflicts between code and error metafile, the PR pingcap/errors#31 remove workaround/description options.

What is changed and how it works?

Adopt the latest version of errors.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

lonng added 2 commits November 8, 2020 20:46
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Copy link
Copy Markdown
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@amyangfei, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack).

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Nov 9, 2020
@crazycs520
Copy link
Copy Markdown
Contributor

/run-all-tests

@lonng
Copy link
Copy Markdown
Contributor Author

lonng commented Nov 9, 2020

/run-cherry-picker

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 failed

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 failed

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 failed

@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants