separate auto_increment ID from row ID#1354
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| // the tables with version < TableInfoVersion5 still use a single allocator for auto_increment and _tidb_rowid. | ||
| // Also see https://github.com/pingcap/tidb/issues/982. | ||
| TableInfoVersion4 = uint16(4) | ||
| TableInfoVersion5 = uint16(5) |
There was a problem hiding this comment.
?? what happened to version 4
There was a problem hiding this comment.
Version 4 is introduced in #1170... but the TiDB part is not merged.
It is released to v5.0, so we need another version to identify that the auto IDs are separated.
tangenta
changed the title
|
@tangenta: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Since the parser is moved to TiDB repo, I am going to close this PR. |
3 participants
What problem does this PR solve?
The parser part of pingcap/tidb#28448.
What is changed and how it works?
alter table t modify [force] row_id = xxx. This is useful in the last stage when importing with Lightning.ActionRebaseRowID.TableInfoVersion4toTableInfoVersion5.TableInfoVersion4is a version that is equivalent toTableInfoVersion3for some reasons.Check List
Tests
Code changes
NA
Side effects
NA
Related changes
NA