Initial attempt to add ON UPDATE support. #286
Closed
EmmaLouise2018 wants to merge 1 commit into
Closed
Conversation
…reduce/reduce conflicts
|
Emma Etherington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
This issue is better resolved in the following pr #331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening up this PR, because I am not entirely sure how to completely resolve this issue and would be grateful for some input/suggestions.
What problem does this PR solve?
This PR was opened in reference to #280 in an attempt to add support fo ON UPDATE sql statement
What is changed and how it works?
The change was to try to update the grammar to support
ON UPDATEclauses withoutON DELETEclauses. The changes are NOT complete.Running
make testgenerates aparser.gofile, which when the tests are run they all pass. In addition, all the sql statements I am working with seem to parse correctly. However, the change I am attempting to make also introduces, perhaps unsurprisingly reduce/reduce conflicts that I am not sure how to resolve.This is my first time working with Yacc, and it's been a while since I've defined a grammar. Would be grateful of any input/suggestions on how to resolve these conflicts or if there is a better approach for how to add this support in the first place.
Side effects
This is currently introducing reduce/reduce conflicts I am unsure how to resolve.