Skip to content

Initial attempt to add ON UPDATE support. #286

Closed
EmmaLouise2018 wants to merge 1 commit into
pingcap:masterfrom
EmmaLouise2018:adding_on_update_support
Closed

Initial attempt to add ON UPDATE support. #286
EmmaLouise2018 wants to merge 1 commit into
pingcap:masterfrom
EmmaLouise2018:adding_on_update_support

Conversation

@EmmaLouise2018
Copy link
Copy Markdown

Opening up this PR, because I am not entirely sure how to completely resolve this issue and would be grateful for some input/suggestions.

What problem does this PR solve?

This PR was opened in reference to #280 in an attempt to add support fo ON UPDATE sql statement

What is changed and how it works?

The change was to try to update the grammar to support ON UPDATE clauses without ON DELETE clauses. The changes are NOT complete.

Running make test generates a parser.go file, which when the tests are run they all pass. In addition, all the sql statements I am working with seem to parse correctly. However, the change I am attempting to make also introduces, perhaps unsurprisingly reduce/reduce conflicts that I am not sure how to resolve.

This is my first time working with Yacc, and it's been a while since I've defined a grammar. Would be grateful of any input/suggestions on how to resolve these conflicts or if there is a better approach for how to add this support in the first place.

Side effects

This is currently introducing reduce/reduce conflicts I am unsure how to resolve.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Emma Etherington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@EmmaLouise2018
Copy link
Copy Markdown
Author

This issue is better resolved in the following pr #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants