mysql: update sql-mode default#45
Merged
Merged
Conversation
Change TiDB to use same default as MySQL 5.7
Contributor
Author
|
See also: pingcap/docs#728 -- it turns out TiDB has great support for MySQL's SQL modes. It just doesn't enable them all by default like mysql does :-) |
Collaborator
|
LGTM @zimulala |
Collaborator
|
Ping @zimulala |
Member
|
should we file a PR in TiDB to test this change? @morgo @tiancaiamao |
Contributor
Author
|
@zz-jason The corresponding TiDB PR is pingcap/tidb#8278 NO_ZERO_DATE did break the set suite, but it's since been fixed. |
Collaborator
Contributor
Author
|
I have created pingcap/tidb#8956 in the TiDB project so the result from the full test suite can be seen while waiting for this PR to merge. |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Change TiDB to use same default as MySQL 5.7
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Change TiDB to use same default as MySQL 5.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change TiDB to use the same default as MySQL 5.7
Depends on pingcap/tidb#8278 (merged)