Skip to content

support CREATE VIEW ... UnionStmt (#572)#574

Merged
kennytm merged 1 commit into
pingcap:release-3.0from
XuHuaiyu:release-3.0
Oct 11, 2019
Merged

support CREATE VIEW ... UnionStmt (#572)#574
kennytm merged 1 commit into
pingcap:release-3.0from
XuHuaiyu:release-3.0

Conversation

@XuHuaiyu
Copy link
Copy Markdown
Contributor

cherry-pick #572

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@2a177b2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0     #574   +/-   ##
==============================================
  Coverage               ?   50.99%           
==============================================
  Files                  ?       31           
  Lines                  ?     6844           
  Branches               ?        0           
==============================================
  Hits                   ?     3490           
  Misses                 ?     3005           
  Partials               ?      349
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
ast/ddl.go 44.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a177b2...c78488f. Read the comment docs.

Copy link
Copy Markdown
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Oct 11, 2019
@kennytm kennytm merged commit 1f407b3 into pingcap:release-3.0 Oct 11, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.0 branch October 12, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants