Skip to content

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs#581

Merged
kennytm merged 2 commits into
pingcap:masterfrom
tsthght:pri
Oct 18, 2019
Merged

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs#581
kennytm merged 2 commits into
pingcap:masterfrom
tsthght:pri

Conversation

@tsthght
Copy link
Copy Markdown
Contributor

@tsthght tsthght commented Oct 17, 2019

What problem does this PR solve?

for pingcap/tidb#12330

What is changed and how it works?

remove GrantPriv from AllGlobalPrivs, AllDBPrivs, AllTablePrivs

Check List

@tsthght tsthght requested a review from a team October 17, 2019 01:13
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 17, 2019

CLA assistant check
All committers have signed the CLA.

@tiancaiamao
Copy link
Copy Markdown
Collaborator

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Oct 18, 2019
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 18, 2019
@kennytm kennytm merged commit 448f044 into pingcap:master Oct 18, 2019
@AilinKid
Copy link
Copy Markdown
Contributor

AilinKid commented Oct 21, 2019

should we modify c.Assert(len(mysql.Priv2UserCol), Equals, len(mysql.AllGlobalPrivs)) in privilege_test.go to pass the build-integration CI here? @kennytm

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Oct 21, 2019

@AilinKid Yes you're supposed to follow up on the TiDB repository to update the test cases given the latest parser.

@ekalinin
Copy link
Copy Markdown
Contributor

Fixed tests here:

imtbkcat pushed a commit to imtbkcat/parser that referenced this pull request Dec 6, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
…p#581)

* remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs

* handle testcase error
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
…p#581)

* remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs

* handle testcase error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants