Skip to content

parser: recognize BACKUP … SNAPSHOT = TSO in additional to SNAPSHOT = 'TIMESTAMP'#782

Merged
kennytm merged 2 commits into
masterfrom
kennytm/backup-tso
Mar 23, 2020
Merged

parser: recognize BACKUP … SNAPSHOT = TSO in additional to SNAPSHOT = 'TIMESTAMP'#782
kennytm merged 2 commits into
masterfrom
kennytm/backup-tso

Conversation

@kennytm
Copy link
Copy Markdown
Contributor

@kennytm kennytm commented Mar 18, 2020

What problem does this PR solve?

In a BACKUP statement (#746), the backup snapshot can also be a TSO.

What is changed and how it works?

Added the backup option SNAPSHOT = uint64

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@kennytm kennytm requested a review from a team March 18, 2020 10:58
@ghost ghost requested review from tangenta and removed request for a team March 18, 2020 10:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2020

Codecov Report

Merging #782 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   78.04%   78.04%   +<.01%     
==========================================
  Files          40       40              
  Lines       14660    14664       +4     
==========================================
+ Hits        11441    11445       +4     
  Misses       2537     2537              
  Partials      682      682

Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 LGT1 label Mar 19, 2020
@kennytm
Copy link
Copy Markdown
Contributor Author

kennytm commented Mar 19, 2020

PTAL @tiancaiamao

@tiancaiamao
Copy link
Copy Markdown
Collaborator

LGTM

@kennytm kennytm merged commit f2d27a3 into master Mar 23, 2020
@kennytm kennytm deleted the kennytm/backup-tso branch March 23, 2020 07:25
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants