config: add scan limit debug config#1637
Conversation
Signed-off-by: dongmen <414110582@qq.com>
There was a problem hiding this comment.
Summary of Changes
Hello @asddongmen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new debug configuration option to control the scan limit for the event service. Previously, this limit was a hardcoded constant, but now it can be configured, providing more flexibility for debugging and performance tuning of the event processing.
Highlights
- Configuration: Added a new "ScanLimitInBytes" field to the "EventServiceConfig" struct in "pkg/config/debug.go", allowing the scan limit for the event service to be configured.
- Event Service Rate Limiting: Modified the "newEventBroker" function in "pkg/eventservice/event_broker.go" to initialize the "scanRateLimiter" using the newly introduced "ScanLimitInBytes" from the debug configuration, replacing a previously hardcoded value.
- Constant Removal: Removed the "maxScanLimitInBytesPerSecond" constant from "pkg/eventservice/dispatcher_stat.go" as its value is now sourced from the configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new debug configuration ScanLimitInBytes to make the event service scan rate limit configurable, replacing a hardcoded constant. The implementation is straightforward and correct. My only suggestion is to improve the naming of the new configuration field for better clarity, as it represents a rate (bytes per second).
[LGTM Timeline notifier]Timeline:
|
|
/check-issue-triage-complete |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flowbehappy, hongyunyan, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #1638
What is changed and how it works?
When starting the CDC server, you can use the following configuration to limit the scanning speed of the eventBroker.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note