Skip to content

Support to pass error in ddlEvent#937

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
hongyunyan:ddl-error
Jan 22, 2025
Merged

Support to pass error in ddlEvent#937
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
hongyunyan:ddl-error

Conversation

@hongyunyan
Copy link
Copy Markdown
Collaborator

@hongyunyan hongyunyan commented Jan 22, 2025

What problem does this PR solve?

Issue Number: close #805

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2025
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2025
Comment thread pkg/common/event/ddl_event.go Outdated
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jan 22, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 06:54:58.027606515 +0000 UTC m=+250225.358525919: ☑️ agreed by lidezhu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support pass error in DDLEvent

2 participants