Skip to content

*: fix several integration test cases#943

Merged
ti-chi-bot[bot] merged 6 commits into
pingcap:masterfrom
asddongmen:fix_changefeed_its
Jan 22, 2025
Merged

*: fix several integration test cases#943
ti-chi-bot[bot] merged 6 commits into
pingcap:masterfrom
asddongmen:fix_changefeed_its

Conversation

@asddongmen
Copy link
Copy Markdown
Collaborator

@asddongmen asddongmen commented Jan 22, 2025

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

  1. Fix test case changefeed_dup_error_restart.
  2. Fix test case mysql_sink_retry.
  3. Remove test cases sink_hang and changefeed_auto_stop since they are included in other cases.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
@asddongmen asddongmen marked this pull request as draft January 22, 2025 05:49
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen asddongmen changed the title *: fix test case changefeed_dup_error_restart *: fix several integration test cases Jan 22, 2025
@ti-chi-bot ti-chi-bot Bot added the lgtm label Jan 22, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 07:17:14.615550987 +0000 UTC m=+251561.946470391: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot Bot added the approved label Jan 22, 2025
@asddongmen asddongmen marked this pull request as ready for review January 22, 2025 07:18
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 623af8c into pingcap:master Jan 22, 2025
@asddongmen asddongmen deleted the fix_changefeed_its branch March 31, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants