test: fix gc_safepoint #950
Merged
Merged
Conversation
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
release-note-none
Signed-off-by: dongmen <414110582@qq.com>
ti-chi-bot
Bot
added
size/XL
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
hongyunyan
approved these changes
Jan 23, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Collaborator
Author
|
/hold |
ti-chi-bot
Bot
added
the
do-not-merge/hold
asddongmen
changed the title
gc_safepoint and other casesgc_safepoint
asddongmen
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dongmen 414110582@qq.com
What problem does this PR solve?
Issue Number: ref #442
What is changed and how it works?
Correct the gc service id registered by ticdc.
After creating the changefeed, the coordinator immediately calculates the latest gcSafepoint and updates it to PD (this is to prevent CDC from being unable to block upstream GC during step 3 deletion if the coordinator has not yet uploaded the first gcSafepoint.)
After a changefeed completes Bootstrap, delete its
gcSafepoint(thisgcSafepointis static and does not update; if not deleted, it will cause GC to be stuck for 1 hour until the key expires). To achieve this, I added some logic betweenmaintainerManagerandcoordinatorto notify thecoordinatorthat a changefeed has completed Bootstrap.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note