Skip to content

executor: allow the test involving DELETE FROM ... AS ...#11184

Merged
bb7133 merged 2 commits into
pingcap:masterfrom
kennytm:delete-from-alias
Jul 19, 2019
Merged

executor: allow the test involving DELETE FROM ... AS ...#11184
bb7133 merged 2 commits into
pingcap:masterfrom
kennytm:delete-from-alias

Conversation

@kennytm
Copy link
Copy Markdown
Contributor

@kennytm kennytm commented Jul 10, 2019 •
edited
Loading

What problem does this PR solve?

Fix #11173.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@kennytm kennytm mentioned this pull request Jul 10, 2019
Merged
@kennytm kennytm force-pushed the delete-from-alias branch 2 times, most recently from 8184507 to a8815c0 Compare July 10, 2019 21:08
@kennytm
Copy link
Copy Markdown
Contributor Author

kennytm commented Jul 11, 2019

/run-all-tests

@kennytm kennytm force-pushed the delete-from-alias branch from a8815c0 to 31e60ff Compare July 19, 2019 04:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #11184 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11184   +/-   ##
===========================================
  Coverage   81.7753%   81.7753%           
===========================================
  Files           423        423           
  Lines         92139      92139           
===========================================
  Hits          75347      75347           
  Misses        11481      11481           
  Partials       5311       5311

@kennytm kennytm force-pushed the delete-from-alias branch from 31e60ff to b9cce1b Compare July 19, 2019 04:22
@kennytm kennytm marked this pull request as ready for review July 19, 2019 04:22
@kennytm
Copy link
Copy Markdown
Contributor Author

kennytm commented Jul 19, 2019

/run-integration-tests

PTAL @imtbkcat @bb7133

@kennytm kennytm mentioned this pull request Jul 19, 2019
Merged
winkyao
winkyao reviewed Jul 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 Indicates that a PR has LGTM 1. and removed status/all tests passed labels Jul 19, 2019
bb7133
bb7133 reviewed Jul 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2019
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Jul 19, 2019

/run-all-tests

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Jul 19, 2019

/run-common-test

@bb7133 bb7133 merged commit 4b928a5 into pingcap:master Jul 19, 2019
@kennytm kennytm deleted the delete-from-alias branch July 19, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

+1 more reviewer

@winkyao winkyao winkyao left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/test status/LGT2 Indicates that a PR has LGTM 2. type/compatibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aliasing a table with DELETE FROM is syntax error

3 participants

@kennytm @bb7133 @winkyao