*: refine text protocol multiple query response#11263
Merged
Merged
Conversation
Contributor
Author
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11263 +/- ##
===========================================
Coverage 81.5609% 81.5609%
===========================================
Files 423 423
Lines 91301 91301
===========================================
Hits 74466 74466
Misses 11512 11512
Partials 5323 5323 |
Contributor
Author
|
/run-all-tests tidb-test=pr/859 |
Contributor
Author
|
/run-all-tests tidb-test=pr/859 |
|
@lysu does it need to be cherry-picked to release-3.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #11235
the current multi-query response has some problem
in tidb:
in mysql:
tidb will return
-1, -1, 0, but mysql need-1, -1.this PR fix both problems, but leave #4617 to next (because it need change too many code)
What is changed and how it works?
ServerMoreResultsExistsset logicwriteMultiResultsetCheck List
Tests
Code changes
Side effects
Related changes