Skip to content

metrics: add missing TiKVTxnCmdCounter#11292

Merged
coocood merged 2 commits into
pingcap:masterfrom
jackysp:add_miss_metrics
Jul 18, 2019
Merged

metrics: add missing TiKVTxnCmdCounter#11292
coocood merged 2 commits into
pingcap:masterfrom
jackysp:add_miss_metrics

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Jul 17, 2019

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

TiKVTxnCmdCounter is missed in metrics register.

What is changed and how it works?

Add it.

Check List

Tests

  • No code

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2019

Codecov Report

Merging #11292 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11292   +/-   ##
===========================================
  Coverage   81.7211%   81.7211%           
===========================================
  Files           423        423           
  Lines         91718      91718           
===========================================
  Hits          74953      74953           
  Misses        11469      11469           
  Partials       5296       5296

@jackysp
Copy link
Copy Markdown
Contributor Author

jackysp commented Jul 18, 2019

/run-all-tests

Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 18, 2019
@coocood coocood merged commit 1768bf4 into pingcap:master Jul 18, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 18, 2019

cherry pick to release-2.1 in PR #11315

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 18, 2019

cherry pick to release-3.0 in PR #11316

@jackysp jackysp deleted the add_miss_metrics branch February 27, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/metrics status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants