executor: expose chunk.Column to prepare for vectorized expression evaluation#11351
Merged
Conversation
qw4990
requested review from
SunRunAway,
XuHuaiyu,
coocood,
wshwsh12 and
zz-jason
Member
|
LGTM |
Contributor
Author
|
/run-all-tests |
SunRunAway
reviewed
Jul 22, 2019
SunRunAway
approved these changes
Jul 22, 2019
SunRunAway
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #11351 +/- ##
=========================================
Coverage 81.325% 81.325%
=========================================
Files 423 423
Lines 90506 90506
=========================================
Hits 73604 73604
Misses 11590 11590
Partials 5312 5312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Expose
chunk.Columnand some methods of it to letExpressioncan access data directly by it instead of usingRowandRowIter, which is prepared for vectorized expression evaluation.What is changed and how it works?
Just expose
chunk.Columnand some methods of it.No logical changes.