Skip to content

expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. (#11251)#11354

Merged
zz-jason merged 4 commits into
pingcap:release-3.0from
SunRunAway:automated-cherry-pick-of-#11251-upstream-release-3.0
Jul 22, 2019
Merged

expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. (#11251)#11354
zz-jason merged 4 commits into
pingcap:release-3.0from
SunRunAway:automated-cherry-pick-of-#11251-upstream-release-3.0

Conversation

@SunRunAway
Copy link
Copy Markdown
Contributor

Automated cherry pick of #11251 on release-3.0.
#11251: Fix #11211
Fix mul and minus
add unit test
add test for add and div

@SunRunAway
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

Copy link
Copy Markdown
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway changed the title expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. (#11251) Jul 22, 2019
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 22, 2019
@zz-jason zz-jason merged commit 2348c75 into pingcap:release-3.0 Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants