ddl: disallow dropping index on auto_increment column#11360
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11360 +/- ##
================================================
- Coverage 81.5135% 81.2498% -0.2637%
================================================
Files 423 423
Lines 91045 90170 -875
================================================
- Hits 74214 73263 -951
- Misses 11541 11597 +56
- Partials 5290 5310 +20 |
Codecov Report
@@ Coverage Diff @@
## master #11360 +/- ##
================================================
- Coverage 81.3368% 81.2376% -0.0992%
================================================
Files 423 423
Lines 90392 90170 -222
================================================
- Hits 73522 73252 -270
- Misses 11577 11605 +28
- Partials 5293 5313 +20 |
zimulala
reviewed
Jul 22, 2019
ngaut
reviewed
Jul 23, 2019
ngaut
reviewed
Jul 23, 2019
Member
|
LGTM |
Member
|
/run-all-tests |
ngaut
approved these changes
Jul 23, 2019
Contributor
|
cherry pick to release-3.0 failed |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jul 24, 2019
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jul 24, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 26, 2019
sre-bot
pushed a commit
that referenced
this pull request
Jul 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiDB:
MySQL 5.7:
What is changed and how it works?
When
DropIndex(), checkAutoIncrementflag in indexed columns.Check List
Tests
Related changes