executor: add vectorized data access methods to Column#11368
Merged
Conversation
qw4990
changed the title
Column and ChunkColumn
Codecov Report
@@ Coverage Diff @@
## master #11368 +/- ##
================================================
- Coverage 81.5947% 81.2722% -0.3225%
================================================
Files 423 423
Lines 91577 90310 -1267
================================================
- Hits 74722 73397 -1325
- Misses 11552 11608 +56
- Partials 5303 5305 +2 |
coocood
reviewed
Jul 22, 2019
coocood
reviewed
Jul 22, 2019
zz-jason
reviewed
Jul 22, 2019
Member
There was a problem hiding this comment.
should we consider unsigned float32 and float64?
Contributor
Author
There was a problem hiding this comment.
Rename it to Decimals;
coocood
reviewed
Jul 22, 2019
Member
|
/run-all-tests |
XuHuaiyu
added
status/LGT2
qw4990
force-pushed
the
vecexpr-column-vec-API
branch
from
b9c7a17 to
21db4a1
Compare
Contributor
Author
|
/run-all-tests |
Member
|
LGTM |
Contributor
Author
coocood
approved these changes
Jul 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add some vectorized data access methods to
Columnto letExpressioncan access its data directly instead of usingRowandRowIter, which is prepared for vectorized expression evaluation.What is changed and how it works?
Two kinds of data access methods are added to
Column:i64,f64,MyDecimal;JSON,String;And
IsNullis exposed.Most of these changes are new methods or unit tests, so it's easy for you to review although there are hundreds of lines changed.
Check List
Tests