Skip to content

planner: fix bugs and make it more effective in outer join elimination rule. (#11160)#11377

Merged
sre-bot merged 23 commits into
pingcap:release-3.0from
lzmhhh123:automated-cherry-pick-of-#11160-origin-release-3.0
Jul 29, 2019
Merged

planner: fix bugs and make it more effective in outer join elimination rule. (#11160)#11377
sre-bot merged 23 commits into
pingcap:release-3.0from
lzmhhh123:automated-cherry-pick-of-#11160-origin-release-3.0

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 commented Jul 23, 2019

Automated cherry pick of #11160 on release-3.0

@lzmhhh123 lzmhhh123 changed the title planner: fix bugs and make it more effective in outer join elimination rule. (#11160) Automated cherry pick of #11160 on release-3.0. #11160: fix bug in in outer_join_elimination fix bug address comments fix parentCols when meeting logicalAgg address comments merge two judge cols in outerplan functions address comments add comments for "if len(cols) == 0" address comments address comments rm make slice & use copy instead directly assign fix improve readability reuse the origin buffer address comments planner: fix bugs and make it more effective in outer join elimination rule. (#11160) Jul 23, 2019
@lzmhhh123 lzmhhh123 added sig/planner SIG: Planner priority/release-blocker This issue blocks a release. Please solve it ASAP. type/bugfix This PR fixes a bug. labels Jul 23, 2019
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

Comment thread planner/core/plan.go
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@zz-jason zz-jason requested a review from eurekaka July 24, 2019 11:04
Copy link
Copy Markdown
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason closed this Jul 28, 2019
@zz-jason zz-jason reopened this Jul 28, 2019
@zz-jason
Copy link
Copy Markdown
Member

/rebuild

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit aede000 into pingcap:release-3.0 Jul 29, 2019
@lzmhhh123 lzmhhh123 deleted the automated-cherry-pick-of-#11160-origin-release-3.0 branch July 29, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants