executor: refactor some methods of Row and Chunk#11380
Merged
Merged
Conversation
qw4990
changed the title
RowRow to let it use vectorized Column API
qw4990
force-pushed
the
vecexpr-row-refactor
branch
from
696ef19 to
dd4e852
Compare
zz-jason
reviewed
Jul 23, 2019
Member
There was a problem hiding this comment.
how about only returning a reference of MyDecimal?
Contributor
Author
There was a problem hiding this comment.
fixed, and it returns a pointer now.
Member
|
/run-all-tests |
coocood
reviewed
Jul 23, 2019
Member
There was a problem hiding this comment.
Can we change GetDecimal to return pointer?
Codecov Report
@@ Coverage Diff @@
## master #11380 +/- ##
===========================================
Coverage ? 81.2914%
===========================================
Files ? 423
Lines ? 90392
Branches ? 0
===========================================
Hits ? 73481
Misses ? 11602
Partials ? 5309 |
qw4990
force-pushed
the
vecexpr-row-refactor
branch
from
b7235fa to
0b7ce59
Compare
Member
|
LGTM |
zz-jason
approved these changes
Jul 23, 2019
qw4990
changed the title
Row to let it use vectorized Column APIRow and Chunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refactor some code of
Row, which is prepared for introducingSeltoChunk.What is changed and how it works?
Chunkwhich only used in tests;Rowto use vectorizedColumnAPI;Column;All changes are refactoring or new methods, so it's easy to review.
Check List
Tests