Skip to content

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11382

Closed
lzmhhh123 wants to merge 5 commits into
pingcap:release-2.1from
lzmhhh123:automated-cherry-pick-of-#11110-origin-release-2.1
Closed

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11382
lzmhhh123 wants to merge 5 commits into
pingcap:release-2.1from
lzmhhh123:automated-cherry-pick-of-#11110-origin-release-2.1

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 commented Jul 23, 2019

Automated cherry pick of #11110 on release-2.1.
#11110: executor: fix autoid doesn't handle float, double type and tiny cleanup

@winoros winoros changed the title executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110) Automated cherry pick of #11110 on release-2.1. #11110: executor: fix autoid doesn't handle float, double type executor: fix autoid doesn't handle float, double type executor: handle update case of autoid bug(#11109), and executor: fix gofmt executor: fix autoid value of insert type and add more executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110) Jul 23, 2019
@lzmhhh123 lzmhhh123 added sig/execution SIG execution type/2.1 cherry-pick type/bugfix This PR fixes a bug. labels Jul 23, 2019
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

1 similar comment
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Comment thread executor/write.go Outdated
Comment thread executor/insert_common.go Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is different from #11110

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check it.

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 force-pushed the automated-cherry-pick-of-#11110-origin-release-2.1 branch from f91110a to 27b0844 Compare July 23, 2019 08:48
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

Some errors with this cherry-pick PR. Close it and create another one.

@lzmhhh123 lzmhhh123 closed this Jul 23, 2019
@lzmhhh123 lzmhhh123 deleted the automated-cherry-pick-of-#11110-origin-release-2.1 branch July 23, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants