Skip to content

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11385

Merged
eurekaka merged 8 commits into
pingcap:release-3.0from
lzmhhh123:automated-cherry-pick-of-#11110-origin-release-3.0
Jul 26, 2019
Merged

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11385
eurekaka merged 8 commits into
pingcap:release-3.0from
lzmhhh123:automated-cherry-pick-of-#11110-origin-release-3.0

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

Automated cherry pick of #11110 on release-3.0.
#11110: executor: fix autoid doesn't handle float, double type
executor: fix autoid doesn't handle float, double type
executor: handle update case of autoid bug(#11109), and
executor: fix gofmt
executor: fix autoid value of insert type and add more

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/rebuild

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

2 similar comments
@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@lzmhhh123
Copy link
Copy Markdown
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@zz-jason zz-jason requested a review from eurekaka July 24, 2019 11:03
@imtbkcat
Copy link
Copy Markdown

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@imtbkcat
Copy link
Copy Markdown

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

Copy link
Copy Markdown

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 26, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 26, 2019

/run-all-tests

@imtbkcat
Copy link
Copy Markdown

/run-unit-test

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2019
@eurekaka eurekaka merged commit 5bb3c06 into pingcap:release-3.0 Jul 26, 2019
@lzmhhh123 lzmhhh123 deleted the automated-cherry-pick-of-#11110-origin-release-3.0 branch September 25, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants