Skip to content

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11389

Merged
zz-jason merged 3 commits into
pingcap:release-2.1from
lzmhhh123:release-2.1-cherry-pick-11110
Jul 23, 2019
Merged

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110)#11389
zz-jason merged 3 commits into
pingcap:release-2.1from
lzmhhh123:release-2.1-cherry-pick-11110

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

cherry-pick #11110.
#11110: executor: fix autoid doesn't handle float, double type and tiny cleanup

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from eurekaka July 23, 2019 09:26
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@zz-jason
Copy link
Copy Markdown
Member

/run-all-tests

Copy link
Copy Markdown

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
@zz-jason zz-jason merged commit 81891c5 into pingcap:release-2.1 Jul 23, 2019
@lzmhhh123 lzmhhh123 deleted the release-2.1-cherry-pick-11110 branch July 24, 2019 05:51
bb7133 added a commit to bb7133/tidb that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants