Skip to content

types: fix delete error when convert string to float or int (#10861)#11471

Closed
amyangfei wants to merge 3 commits into
pingcap:release-3.0from
amyangfei:pick-10861-3.0
Closed

types: fix delete error when convert string to float or int (#10861)#11471
amyangfei wants to merge 3 commits into
pingcap:release-3.0from
amyangfei:pick-10861-3.0

Conversation

@amyangfei
Copy link
Copy Markdown
Contributor

cherry-pick #10861 to release-3.0

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@amyangfei
Copy link
Copy Markdown
Contributor Author

PTAL @zz-jason @qw4990

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2019
@zz-jason zz-jason requested review from alivxxx and qw4990 July 27, 2019 02:00
@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-unit-tests

Copy link
Copy Markdown
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 28, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jul 28, 2019

@amyangfei merge failed.

@qw4990 qw4990 removed their request for review July 29, 2019 02:00
@amyangfei amyangfei closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants