Skip to content

ddl: fix invalid index on multi-layer virtual columns (#11260)#11475

Merged
sre-bot merged 7 commits into
pingcap:release-3.0from
tangenta:release-3.0-multi-layer-vir-col
Aug 5, 2019
Merged

ddl: fix invalid index on multi-layer virtual columns (#11260)#11475
sre-bot merged 7 commits into
pingcap:release-3.0from
tangenta:release-3.0-multi-layer-vir-col

Conversation

@tangenta
Copy link
Copy Markdown
Contributor

Cherry-pick #11260.

@tangenta
Copy link
Copy Markdown
Contributor Author

/run-all-tests

Copy link
Copy Markdown
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Copy Markdown
Contributor

winkyao commented Jul 28, 2019

/run-common-test

@winkyao winkyao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jul 28, 2019
@winkyao
Copy link
Copy Markdown
Contributor

winkyao commented Jul 28, 2019

/run-all-tests

@tangenta
Copy link
Copy Markdown
Contributor Author

randgen test keeps failing:

 2019/07/28 16:31:49.196 main.go:713: [fatal] run test [udaf_bitor_union] err: sql:select bit_or(`col_decimal_10_4_unsigned_key`) as a from (select * from `table70_int_autoinc` union all select * from `table80_int_autoinc`) tmp group by tmp.`col_decimal_10_4_unsigned` order by a;: failed to run query
 "select bit_or(`col_decimal_10_4_unsigned_key`) as a from (select * from `table70_int_autoinc` union all select * from `table80_int_autoinc`) tmp group by tmp.`col_decimal_10_4_unsigned` order by a;"
 around line 566,
 we need(245):
 select bit_or(`col_decimal_10_4_unsigned_key`) as a from (select * from `table70_int_autoinc` union all select * from `table80_int_autoinc`) tmp group by tmp.`col_decimal_10_4_unsigned` order by a;
 a
 0
 0
 0
 0
 0
 0
 0
 0
 0
 0
 0
 1
 1
 1
 1
 12
 12
 13
 63
 94

 but got(245):
 select bit_or(`col_decimal_10_4_unsigned_key`) as a from (select * from `table70_int_autoinc` union all select * from `table80_int_autoinc`) tmp group by tmp.`col_decimal_10_4_unsigned` order by a;
 a
 0
 0
 0
 0
 0
 0
 0
 0
 0
 0
 0
 1
 1
 1
 1
 13
 13
 13
 63
 95



@amyangfei
Copy link
Copy Markdown
Contributor

amyangfei commented Jul 28, 2019

randgen test keeps failing:

@tangenta this is because #11295 changed some mysql-test test cases, but the cherry-pick to 3.0, #11469 has not been merged

zimulala
zimulala previously approved these changes Aug 2, 2019
Copy link
Copy Markdown
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 2, 2019

@tangenta merge failed.

@zz-jason
Copy link
Copy Markdown
Member

zz-jason commented Aug 3, 2019

/run-unit-test

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 3, 2019
@winkyao
Copy link
Copy Markdown
Contributor

winkyao commented Aug 4, 2019

/run-unit-test

@tangenta
Copy link
Copy Markdown
Contributor Author

tangenta commented Aug 4, 2019

/run-all-tests

@tangenta
Copy link
Copy Markdown
Contributor Author

tangenta commented Aug 5, 2019

[2019-08-04T14:44:52.655Z] 2019/08/04 22:44:52.542 main.go:821: [fatal] run test [window_functions] err: sql:SELECT SUM(DISTINCT b) OVER () FROM t;: failed to run query 

[2019-08-04T14:44:52.655Z] "SELECT SUM(DISTINCT b) OVER () FROM t;" 

[2019-08-04T14:44:52.655Z]  around line 1004, 

[2019-08-04T14:44:52.655Z] we need(117):

[2019-08-04T14:44:52.655Z] SELECT SUM(DISTINCT b) OVER () FROM t;

[2019-08-04T14:44:52.655Z] Error 1235: This version of TiDB doesn't yet support '<window function>(DISTIN

[2019-08-04T14:44:52.655Z] but got(117):

[2019-08-04T14:44:52.655Z] SELECT SUM(DISTINCT b) OVER () FROM t;

[2019-08-04T14:44:52.655Z] SUM(DISTINCT b) OVER ()

[2019-08-04T14:44:52.655Z] 36

[2019-08-04T14:44:52.655Z] 36

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 5, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit a91e3a4 into pingcap:release-3.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants