executor: fix data race in (*HashJoinExec).Close() since fetchInnerAndBuildHashTable is still running#11639
Merged
Merged
Conversation
Contributor
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11639 +/- ##
================================================
- Coverage 81.4489% 81.4471% -0.0018%
================================================
Files 433 433
Lines 93240 93091 -149
================================================
- Hits 75943 75820 -123
+ Misses 11867 11846 -21
+ Partials 5430 5425 -5 |
Contributor
Author
|
/run-all-tests |
zz-jason
reviewed
Aug 6, 2019
Member
zz-jason
left a comment
zz-jason
left a comment
There was a problem hiding this comment.
Please add an UT for the bug-fixes. You can write a failpoint test.
zz-jason
reviewed
Aug 6, 2019
Member
zz-jason
left a comment
zz-jason
left a comment
There was a problem hiding this comment.
Please add an UT for the bug-fixes. You can write a failpoint test.
zz-jason
added
status/can-merge
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #11600, and fixes #11693
What is changed and how it works?
It's a bug introduced by #11571
Check List
Tests
Code changes
Side effects
Related changes