expression: remove unnecessary convertIntToUint. fix error in err msg(should be bigint but not double)#11640
Merged
Merged
Conversation
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
added
needs-cherry-pick-2.1
component/expression
type/bugfix
lonng
reviewed
Aug 7, 2019
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
force-pushed
the
fix-bug-of-builtin_cast
branch
from
d262020 to
746396e
Compare
Codecov Report
@@ Coverage Diff @@
## master #11640 +/- ##
================================================
- Coverage 81.6732% 81.2142% -0.4591%
================================================
Files 429 426 -3
Lines 93688 91830 -1858
================================================
- Hits 76518 74579 -1939
- Misses 11772 11889 +117
+ Partials 5398 5362 -36 |
Codecov Report
@@ Coverage Diff @@
## master #11640 +/- ##
===============================================
- Coverage 81.8533% 81.442% -0.4114%
===============================================
Files 430 429 -1
Lines 94800 92618 -2182
===============================================
- Hits 77597 75430 -2167
- Misses 11773 11798 +25
+ Partials 5430 5390 -40 |
XuHuaiyu
reviewed
Aug 12, 2019
Contributor
XuHuaiyu
left a comment
XuHuaiyu
left a comment
There was a problem hiding this comment.
Address the comment makes this a LGTM~
| } | ||
|
|
||
| // ConvertFloatToInt converts a float64 value to a int value. | ||
| // |
Contributor
There was a problem hiding this comment.
We can remove this useless line.
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
…fix-bug-of-builtin_cast
Contributor
|
/run-all-tests |
zz-jason
added
status/LGT2
Contributor
|
cherry pick to release-2.1 failed |
Contributor
|
cherry pick to release-3.0 in PR #11707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
In some of the code, we get a uint from the row which is stored in int, however, we needn't casting it from int to uint when it is uint, this will make some bugs.
In the origin
builtinCastStringAsDecimalSig::evalDecimal, the res is always not neg, this is a bug.What is changed and how it works?
Check List
Tests
Code changes
NO.
Side effects
NO.
Related changes