*: refine the attribute definition of types.Time and types.Duration#11672
Merged
Conversation
XuHuaiyu
added
type/enhancement
Contributor
Author
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11672 +/- ##
===============================================
- Coverage 82.0336% 81.4276% -0.606%
===============================================
Files 433 432 -1
Lines 96497 93090 -3407
===============================================
- Hits 79160 75801 -3359
- Misses 11744 11870 +126
+ Partials 5593 5419 -174 |
zz-jason
reviewed
Aug 12, 2019
qw4990
reviewed
Aug 13, 2019
qw4990
reviewed
Aug 13, 2019
qw4990
reviewed
Aug 13, 2019
lzmhhh123
reviewed
Aug 13, 2019
tiancaiamao
reviewed
Aug 13, 2019
Contributor
tiancaiamao
left a comment
tiancaiamao
left a comment
There was a problem hiding this comment.
I have no problem with the change of fsp from int to int8, and change hour to int16 seems ok.
But why mytime.go is modified?
alivxxx
reviewed
Aug 13, 2019
zz-jason
reviewed
Aug 13, 2019
Contributor
Author
|
/run-all-tests |
alivxxx
reviewed
Aug 13, 2019
| "time" | ||
|
|
||
| . "github.com/pingcap/check" | ||
| "unsafe" |
Contributor
There was a problem hiding this comment.
Put it with system packages?
alivxxx
added
status/LGT2
Contributor
|
/run-all-tests |
Contributor
|
@XuHuaiyu merge failed. |
Contributor
Author
|
/run-common-test tidb-test=pr/874 |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
1 similar comment
Contributor
Author
|
/run-unit-test |
alivxxx
approved these changes
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
types.MysqlTime.hourfrominttouint32types.Time.Fspfrominttoint8types.Duration.Fspfrominttoint8After 1 and 2, the memory usage of a Time struct will be reduced from 40bytes to 20 bytes.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
N/A
Related changes