executor: fix panic when fetching processlist table data in some cases#11690
Merged
Conversation
Member
|
This is a serious issue, we should cherry-pick it to version 3.0. |
Contributor
Author
ngaut
added
status/can-merge
Contributor
|
/run-all-tests |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When TiDB fetches data from
processlisttable, it will get each connection's memory consumption according to theirCtx.Memtracker.But in some cases,
Ctx.Memtrackeris not initialized at that time, which results in a panic.What is changed and how it works?
Check if
Ctx.Memtrackerisnilbefore using it when fetchingprocesslisttable data.