executor: add reserve methods to Column for var-length types#11699
Merged
Conversation
qw4990
force-pushed
the
vecexpr-resize-reserve
branch
2 times, most recently
from
4c71af1 to
273d52f
Compare
Codecov Report
@@ Coverage Diff @@
## master #11699 +/- ##
================================================
- Coverage 81.7341% 81.4407% -0.2935%
================================================
Files 430 429 -1
Lines 94269 92746 -1523
================================================
- Hits 77050 75533 -1517
- Misses 11796 11821 +25
+ Partials 5423 5392 -31 |
zz-jason
reviewed
Aug 9, 2019
Member
There was a problem hiding this comment.
Suggested change
| //reserve makes the column capacity be at least enough to contain n elements. | |
| // reserve makes the column capacity be at least enough to contain n elements. |
qw4990
force-pushed
the
vecexpr-resize-reserve
branch
from
273d52f to
25faea3
Compare
coocood
reviewed
Aug 9, 2019
qw4990
force-pushed
the
vecexpr-resize-reserve
branch
from
25faea3 to
5d1ad8e
Compare
Member
|
LGTM |
XuHuaiyu
reviewed
Aug 12, 2019
Contributor
XuHuaiyu
left a comment
XuHuaiyu
left a comment
There was a problem hiding this comment.
The title for this PR should be more specific
qw4990
force-pushed
the
vecexpr-resize-reserve
branch
from
5d1ad8e to
3076f7e
Compare
zz-jason
added
status/can-merge
Contributor
|
/run-all-tests |
update comment update comment update update comments add UT address comments address comment add comment
qw4990
force-pushed
the
vecexpr-resize-reserve
branch
from
fab6a7c to
27913b8
Compare
qw4990
removed
the
status/can-merge
Contributor
Author
zz-jason
approved these changes
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add reserve methods to
Columnfor var-length types to reserve memory before using aColumn.And rename methods
PreAllocXXXtoResizeXXX.What is changed and how it works?
JSON,Enum,Bytes,SetandString;PreAllocXXXmethods.Check List
Tests