expression: fix last_day incompatible with mysql#11704
Merged
Merged
Conversation
Contributor
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Codecov Report
@@ Coverage Diff @@
## master #11704 +/- ##
===============================================
- Coverage 81.6469% 81.441% -0.2059%
===============================================
Files 429 429
Lines 93614 92597 -1017
===============================================
- Hits 76433 75412 -1021
- Misses 11780 11796 +16
+ Partials 5401 5389 -12 |
Codecov Report
@@ Coverage Diff @@
## master #11704 +/- ##
===========================================
Coverage 81.4323% 81.4323%
===========================================
Files 429 429
Lines 92645 92645
===========================================
Hits 75443 75443
Misses 11808 11808
Partials 5394 5394 |
Member
|
@TennyZhuang Thanks for your contribution. Can you modify the PR description to use the "Closing issues using keywords" feature of github? It helps us to automatically close the issue when this PR is merged. |
Contributor
Author
|
@zz-jason Updated |
ngaut
added
status/LGT2
ngaut
approved these changes
Aug 10, 2019
Contributor
|
/run-all-tests |
Contributor
|
@TennyZhuang merge failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #11695
What is changed and how it works?
Changed is described in issue.
Assert day is not 0 before calculate last_da
Check List
Tests
Code changes
Side effects
Related changes