*: use bytes.Equal to check byte slice equivalent#11706
Merged
Conversation
amyangfei
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #11706 +/- ##
================================================
- Coverage 81.7276% 81.4327% -0.2949%
================================================
Files 430 429 -1
Lines 94279 92631 -1648
================================================
- Hits 77052 75432 -1620
- Misses 11802 11805 +3
+ Partials 5425 5394 -31 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #11706 +/- ##
================================================
- Coverage 81.7276% 81.4327% -0.2949%
================================================
Files 430 429 -1
Lines 94279 92631 -1648
================================================
- Hits 77052 75432 -1620
- Misses 11802 11805 +3
+ Partials 5425 5394 -31 |
Contributor
Author
|
/run-all-tests |
Member
|
Good catch. LGTM. |
ngaut
approved these changes
Aug 11, 2019
Contributor
|
cherry pick to release-3.0 failed |
Contributor
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @amyangfei PTAL. |
Contributor
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-3.0 in PR #16174 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-3.1 in PR #16177 |
zz-jason
pushed a commit
that referenced
this pull request
Apr 13, 2020
zz-jason
pushed a commit
that referenced
this pull request
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
bytes.Equalis faster thanbytes.Compare() == 0simple benchmark code snippet: https://play.golang.org/p/omqWdp4z0S9
What is changed and how it works?
change
bytes.Compare() == 0withbytes.EqualCheck List
Tests
Code changes
Side effects
Related changes