Skip to content

metric, tikv: record duration for each backoff type (#11710)#11728

Merged
zz-jason merged 3 commits into
pingcap:release-3.0from
sre-bot:release-3.0-3d6c56195229
Aug 16, 2019
Merged

metric, tikv: record duration for each backoff type (#11710)#11728
zz-jason merged 3 commits into
pingcap:release-3.0from
sre-bot:release-3.0-3d6c56195229

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Aug 13, 2019

cherry-pick #11710 to release-3.0


What problem does this PR solve?

current "KV Errors" - "KV Retry Duration" metrics in grafana only record coprocessor's backoff time.

that miss:

  • 2pc commit path's backoff
  • kv get path's backoff

it also miss the fine-gain time for each backoff-type

What is changed and how it works?

  • record backoff duration in backoff
  • remove duplicate cop duration recording

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • change metric record

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Aug 13, 2019

/run-all-tests

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2019
@tiancaiamao
Copy link
Copy Markdown
Contributor

LGTM

@tiancaiamao tiancaiamao added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2019
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Aug 16, 2019

Sorry @tiancaiamao, you don't have permission to trigger auto merge event on this branch.

@zz-jason zz-jason merged commit 5dab5e7 into pingcap:release-3.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants