expression, util: add an interface Times for chunk.Column#11742
Merged
Conversation
XuHuaiyu
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #11742 +/- ##
===============================================
- Coverage 81.9352% 81.4583% -0.477%
===============================================
Files 433 433
Lines 95274 93190 -2084
===============================================
- Hits 78063 75911 -2152
- Misses 11778 11853 +75
+ Partials 5433 5426 -7 |
XuHuaiyu
changed the title
Member
|
How much memory allocation increased when we store the |
Contributor
|
/run-all-tests |
Contributor
13 bytes -> 20 bytes. |
Member
@XuHuaiyu Also, could you provide some benchmarks on the evaluation of time values? |
Contributor
Author
|
@zz-jason Added. And the result is added in the description. |
Contributor
Author
Contributor
|
/run-all-tests |
qw4990
added
status/all tests passed
status/can-merge
Contributor
|
/run-all-tests |
qw4990
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Benchmark result
$ GO111MODULE=on go test -bench=BenchmarkTime -run=none goos: darwin goarch: amd64 pkg: github.com/pingcap/tidb/util/chunk BenchmarkTimeRow-4 10000 151708 ns/op BenchmarkTimeVec-4 50000 33028 ns/op PASSCheck List
Tests
Code changes
Side effects
N/A
Related changes
N/A