Skip to content

*: support query block syntax#11761

Merged
ngaut merged 6 commits into
pingcap:masterfrom
alivxxx:parser
Aug 22, 2019
Merged

*: support query block syntax#11761
ngaut merged 6 commits into
pingcap:masterfrom
alivxxx:parser

Conversation

@alivxxx
Copy link
Copy Markdown
Contributor

@alivxxx alivxxx commented Aug 16, 2019

What problem does this PR solve?

Support query block syntax.

What is changed and how it works?

Update parser to pingcap/parser#491

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • None

Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2019

Codecov Report

Merging #11761 into master will decrease coverage by 0.202%.
The diff coverage is 83.3333%.

@@               Coverage Diff                @@
##             master     #11761        +/-   ##
================================================
- Coverage   81.6663%   81.4642%   -0.2021%     
================================================
  Files           435        435                
  Lines         95033      93738      -1295     
================================================
- Hits          77610      76363      -1247     
+ Misses        11919      11897        -22     
+ Partials       5504       5478        -26

@foreyes
Copy link
Copy Markdown
Contributor

foreyes commented Aug 22, 2019

/run-all-tests

Copy link
Copy Markdown
Contributor

@foreyes foreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 22, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 22, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 22, 2019

@lamxTyler merge failed.

@alivxxx
Copy link
Copy Markdown
Contributor Author

alivxxx commented Aug 22, 2019

/run-all-tests

@ngaut ngaut merged commit 73b8e6d into pingcap:master Aug 22, 2019
@alivxxx alivxxx deleted the parser branch August 22, 2019 04:39
foreyes pushed a commit to foreyes/tidb that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/parser status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants